<html>
<head><meta charset="utf-8"><title>Adding -Z self-profile support to rustdoc perf runs · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html">Adding -Z self-profile support to rustdoc perf runs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218373531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218373531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218373531">(Dec 01 2020 at 02:20)</a>:</h4>
<p>I'm trying to fix <a href="https://github.com/rust-lang/rustc-perf/issues/797">https://github.com/rust-lang/rustc-perf/issues/797</a>. I ran collector with <code>--self-profile</code>:</p>
<div class="codehilite"><pre><span></span><code>target/release/collector bench_local $(rustup which rustc) self-profile --builds Doc --runs Full --include stm32h7xx-hal --self-profile
</code></pre></div>
<p>but the website says it doesn't have the information:</p>
<div class="codehilite"><pre><span></span><code>no results found for Query {Crate=One(&quot;stm32h7xx-hal&quot;), Profile=One(&quot;doc&quot;), Cache=One(&quot;full&quot;) } in [Artifact(&quot;self-profile&quot;)]
</code></pre></div>
<p>What else do I need to do? I'm not sure where to look.</p>



<a name="218374093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218374093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218374093">(Dec 01 2020 at 02:31)</a>:</h4>
<p>oh booooo</p>
<div class="codehilite" data-code-language="Diff"><pre><span></span><code><span class="gh">diff --git a/collector/src/execute.rs b/collector/src/execute.rs</span>
<span class="gh">index 527aa85f..0c1078e6 100644</span>
<span class="gd">--- a/collector/src/execute.rs</span>
<span class="gi">+++ b/collector/src/execute.rs</span>
<span class="gu">@@ -725,7 +725,7 @@ impl Upload {</span>

 impl&lt;'a&gt; Processor for MeasureProcessor&lt;'a&gt; {
     fn profiler(&amp;self, build: BuildKind) -&gt; Profiler {
<span class="gd">-        if self.is_first_collection &amp;&amp; self.self_profile &amp;&amp; build != BuildKind::Doc {</span>
<span class="gi">+        if self.is_first_collection &amp;&amp; self.self_profile {</span>
             Profiler::PerfStatSelfProfile
         } else {
             Profiler::PerfStat
</code></pre></div>



<a name="218375052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375052">(Dec 01 2020 at 02:51)</a>:</h4>
<p>the current error is</p>
<div class="codehilite"><pre><span></span><code>thread &#39;main&#39; panicked at &#39;found prefix &quot;/tmp/.tmp6jMNWq/self-profile-output&quot;&#39;, collector/src/rustc-fake.rs:128:45
</code></pre></div>



<a name="218375054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375054">(Dec 01 2020 at 02:51)</a>:</h4>
<p>which from reading the source might mean the file isn't being generated?</p>



<a name="218375096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375096">(Dec 01 2020 at 02:52)</a>:</h4>
<p>it's hard to tell because collector keeps deleting the temp directory</p>



<a name="218375122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375122">(Dec 01 2020 at 02:53)</a>:</h4>
<p>I would check if rustdoc generates self-profile information when run with -Zself-profile</p>



<a name="218375125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375125">(Dec 01 2020 at 02:53)</a>:</h4>
<p>it definitely does, I've used it before</p>



<a name="218375128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375128">(Dec 01 2020 at 02:53)</a>:</h4>
<p>we had all those <code>&lt;unknown&gt;</code>s, remember?</p>



<a name="218375130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375130">(Dec 01 2020 at 02:53)</a>:</h4>
<p>and the other thing to check is whether you have summarize installed locally</p>



<a name="218375137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375137">(Dec 01 2020 at 02:54)</a>:</h4>
<p>yup, I do</p>



<a name="218375171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375171">(Dec 01 2020 at 02:54)</a>:</h4>
<p>and that summarize is 9.0?</p>



<a name="218375176"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375176" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375176">(Dec 01 2020 at 02:54)</a>:</h4>
<p>yup</p>



<a name="218375192"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375192" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375192">(Dec 01 2020 at 02:54)</a>:</h4>
<p>something is quite odd then, because line 128 should not be hit with modern rustdoc/self-profile</p>



<a name="218375202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375202">(Dec 01 2020 at 02:55)</a>:</h4>
<p>we should be in the first branch of that if not the else</p>



<a name="218375229"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375229" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375229">(Dec 01 2020 at 02:55)</a>:</h4>
<p>could this have something to do with it?</p>
<div class="codehilite"><pre><span></span><code>                // Rustdoc does not support incremental compilation
                if build_kind != BuildKind::Doc  {
</code></pre></div>



<a name="218375292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375292">(Dec 01 2020 at 02:56)</a>:</h4>
<p>I shouldn't</p>



<a name="218375294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375294">(Dec 01 2020 at 02:56)</a>:</h4>
<p>it shouldn't</p>



<a name="218375295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375295">(Dec 01 2020 at 02:56)</a>:</h4>
<p>really what I want to do is "only delete the temp directory on sucess"</p>



<a name="218375298"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375298" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375298">(Dec 01 2020 at 02:56)</a>:</h4>
<p>I mean that should be fairly easy</p>



<a name="218375316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375316">(Dec 01 2020 at 02:57)</a>:</h4>
<p>just wrap the TempDir in a ManuallyDrop or something</p>



<a name="218375319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375319">(Dec 01 2020 at 02:57)</a>:</h4>
<p>Or PathBuf or w/e</p>



<a name="218375335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375335">(Dec 01 2020 at 02:58)</a>:</h4>
<p>hm, I wonder if rustdoc properly passes the crate name through</p>



<a name="218375377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375377">(Dec 01 2020 at 02:58)</a>:</h4>
<p>oh that's it, it definitely does not</p>



<a name="218375381"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375381" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375381">(Dec 01 2020 at 02:58)</a>:</h4>
<p>it generates <code>unknown</code> instead <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="218375383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375383">(Dec 01 2020 at 02:58)</a>:</h4>
<p>yeah that's a requirement for the detection</p>



<a name="218375388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375388">(Dec 01 2020 at 02:58)</a>:</h4>
<p>ok, now I have more bugs to fix <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="218375389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375389">(Dec 01 2020 at 02:58)</a>:</h4>
<p><a href="https://github.com/jyn514/rustc-perf/blob/e691ac374c85c7b35aa385447aa3d1725841966a/collector/src/rustc-fake.rs#L91-L94">https://github.com/jyn514/rustc-perf/blob/e691ac374c85c7b35aa385447aa3d1725841966a/collector/src/rustc-fake.rs#L91-L94</a></p>



<a name="218375406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375406">(Dec 01 2020 at 02:58)</a>:</h4>
<p>we might just be able to remove that? not sure tbh</p>



<a name="218375418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375418">(Dec 01 2020 at 02:59)</a>:</h4>
<p>well, it would be nice to fix this on rustdoc's end anyway</p>



<a name="218375423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375423">(Dec 01 2020 at 02:59)</a>:</h4>
<p>I think the intent was to prevent accidental inclusion of other crates, because we're not always running quite right</p>



<a name="218375425"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375425" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375425">(Dec 01 2020 at 02:59)</a>:</h4>
<p>do you happen to know where it <em>should</em> be getting set? Maybe somewhere in <code>Session</code>?</p>



<a name="218375426"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375426" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375426">(Dec 01 2020 at 02:59)</a>:</h4>
<p>but yeah, a fix upstream would be better</p>



<a name="218375434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375434">(Dec 01 2020 at 02:59)</a>:</h4>
<p>no idea, sorry, but that would be my first guess. should be able to grep for measureme, though.</p>



<a name="218375473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375473">(Dec 01 2020 at 03:00)</a>:</h4>
<p>I am also a bit hesitant fwiw to enable rustdoc self-profile due to the additional time it would take, but we can deal with that if it becomes a problem</p>



<a name="218375520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375520">(Dec 01 2020 at 03:00)</a>:</h4>
<p>do you expect it to take that much longer than running rustdoc in the first place?</p>



<a name="218375551"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375551" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375551">(Dec 01 2020 at 03:01)</a>:</h4>
<p>no, but it doubles up our runs because we collect enough to not show self-profile instruction counts by default</p>



<a name="218375559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375559">(Dec 01 2020 at 03:01)</a>:</h4>
<p>ahh I see</p>



<a name="218375564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375564">(Dec 01 2020 at 03:01)</a>:</h4>
<p>well, maybe we can just make it work for <code>build_local</code> for now</p>



<a name="218375573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375573">(Dec 01 2020 at 03:01)</a>:</h4>
<p>yeah for sure</p>



<a name="218375575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375575">(Dec 01 2020 at 03:01)</a>:</h4>
<p>in any case I think we can enable and see</p>



<a name="218375589"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375589" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375589">(Dec 01 2020 at 03:02)</a>:</h4>
<p>we're not too tight on queue space lately</p>



<a name="218375597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375597">(Dec 01 2020 at 03:02)</a>:</h4>
<p>also FWIW I would find it more useful to have <em>only</em> --self-profile and not the less noisy version</p>



<a name="218375622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375622">(Dec 01 2020 at 03:02)</a>:</h4>
<p>Sure, that's another workaround.</p>



<a name="218375635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375635">(Dec 01 2020 at 03:02)</a>:</h4>
<p>anyway, I'm off, night!</p>



<a name="218375641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218375641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218375641">(Dec 01 2020 at 03:02)</a>:</h4>
<p>good night! Thanks for the help :)</p>



<a name="218376694"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218376694" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218376694">(Dec 01 2020 at 03:24)</a>:</h4>
<p>found the issue, this is passing in a None value: <a href="https://github.com/rust-lang/rust/blob/b7ebc6b0c1ba3c27ebb17c0b496ece778ef11e18/compiler/rustc_session/src/session.rs#L1341">https://github.com/rust-lang/rust/blob/b7ebc6b0c1ba3c27ebb17c0b496ece778ef11e18/compiler/rustc_session/src/session.rs#L1341</a></p>



<a name="218376708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Adding%20-Z%20self-profile%20support%20to%20rustdoc%20perf%20runs/near/218376708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Adding.20-Z.20self-profile.20support.20to.20rustdoc.20perf.20runs.html#218376708">(Dec 01 2020 at 03:24)</a>:</h4>
<p>now I just need to find why ...</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>